Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TiDB best practices on public cloud #18313

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Add TiDB best practices on public cloud #18313

merged 12 commits into from
Aug 20, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Aug 7, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. area/best-practices Adds or updates TiDB best practices. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 7, 2024
@qiancai qiancai marked this pull request as draft August 7, 2024 06:43
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. labels Aug 7, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2024
@qiancai qiancai marked this pull request as ready for review August 8, 2024 09:02
@qiancai
Copy link
Collaborator Author

qiancai commented Aug 8, 2024

/cc @dbsid

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2024

@qiancai: GitHub didn't allow me to request PR reviews from the following users: dbsid.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dbsid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Aug 20, 2024

/approve

@qiancai qiancai added the lgtm label Aug 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit f555ded into pingcap:master Aug 20, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18395.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #18396.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18397.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18398.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18399.

This was referenced Aug 20, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18400.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18396)
7406bc5
ti-chi-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18397)
407c7f0
ti-chi-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18398)
9dc13ec
ti-chi-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18400)
446b311
ti-chi-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18395)
ec144a1
@qiancai qiancai added the needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. label Aug 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18414.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 22, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 22, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18399)
70a1c93
ti-chi-bot bot pushed a commit that referenced this pull request Aug 22, 2024
@ti-chi-bot
Add TiDB best practices on public cloud (#18313) (#18414)
8ee81ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@dbsid dbsid dbsid approved these changes

Assignees
No one assigned
Labels
approved area/best-practices Adds or updates TiDB best practices. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiancai @ti-chi-bot @dbsid @hfxsd